Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overhang on home not reshowing when returning from movie library view #1428

Closed
wants to merge 2 commits into from
Closed

Fix overhang on home not reshowing when returning from movie library view #1428

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f93315
Fix home overhang
1hitsong Oct 22, 2023
b98e558
Clean up existing code
1hitsong Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/data/SceneManager.brs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ sub popScene()

group.visible = false

if groupType = "JFScreen"
if LCase(groupType) = "jfscreen" or LCase(groupType) = "movielibraryview"
Copy link
Member

@cewert cewert Oct 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MovieLibraryView.xml extends JFScreen and already has a OnScreenHidden() function so this code shouldn't be needed.

I can't reproduce your bug but I'm pretty sure I broke this in #1374 here. If you change the code back to isSubType() I bet it will work. I was trying to refactor because I thought they did the same thing but the functions work differently see here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OnScreenHidden() wasn't getting called because grouptype is "MovieLibraryView" and not "JFScreen."

It's what you said, the difference between isSubType() and .subtype()

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should close this PR and revert those changes because they can have unentended consequences since it's not checking that the component is extending.

group.callFunc("OnScreenHidden")
end if
else
Expand Down