Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't switch audio tracks #2059

Open
liquidpeachy opened this issue Nov 22, 2024 · 3 comments
Open

Can't switch audio tracks #2059

liquidpeachy opened this issue Nov 22, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@liquidpeachy
Copy link

Software Versions

  • Jellyfin Server Version: 10.9.11
  • Roku Client Version: 2.2.5

Describe the bug

When using direct stream, I'm unable to change the audio track. I have both DTS and AAC codecs as tracks. Even if I select DTS on episode overview screen with *, it still loads aac. If I attempt to change to DTS during the playback, it will will refresh but still have AAC selected.

FFprobe of my media file:

`{
"programs": [

],
"streams": [
    {
        "index": 0,
        "codec_name": "eac3",
        "codec_type": "audio",
        "channels": 6,
        "channel_layout": "5.1(side)",
        "bit_rate": "1024000",
        "side_data_list": [
            {

            }
        ]
    },
    {
        "index": 1,
        "codec_name": "aac",
        "codec_type": "audio",
        "channels": 6,
        "bit_rate": "394508"
    }
]

}
`

Logs

Log for the stream:
https://pastebin.com/uaKkBcTX

@liquidpeachy liquidpeachy added the bug Something isn't working label Nov 22, 2024
@jimdogx
Copy link
Contributor

jimdogx commented Nov 22, 2024

Any chance you can get the Roku log files as well?

https://github.com/jellyfin/jellyfin-roku/blob/master/docs/DEVGUIDE.md#bugcrash-reports

@frothedoatmilk
Copy link
Contributor

Here to say that I'm having a similar issue, but mine is happening with just two stereo audio channels. It will always play the second (commentary) track:

ffprobe:

Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'Avatar The Last Airbender - S02E08 - The Chase.mp4':
  Metadata:
    major_brand     : isom
    minor_version   : 1
    compatible_brands: isom
    creation_time   : 2023-05-22T07:05:57.000000Z
    encoder         : GPAC-2.3-DEV-rev221-g200100727-ab-suite
  Duration: 00:24:37.57, start: 0.000000, bitrate: 1481 kb/s
  Chapters:
    Chapter #0:0: start 0.000000, end 80.000000
      Metadata:
        title           : Intro
    Chapter #0:1: start 80.000000, end 475.642000
      Metadata:
        title           : Part 1
    Chapter #0:2: start 475.642000, end 855.938000
      Metadata:
        title           : Part 2
    Chapter #0:3: start 855.938000, end 1430.971000
      Metadata:
        title           : Part 3
    Chapter #0:4: start 1430.971000, end 1477.566667
      Metadata:
        title           : Outro
  Stream #0:0[0x1](und): Video: hevc (Main 10) (hvc1 / 0x31637668), yuv420p10le(tv, bt709), 1440x1080, 1068 kb/s, 23.98 fps, 23.98 tbr, 24k tbn (default)
    Metadata:
      creation_time   : 2023-05-19T23:37:10.000000Z
      handler_name    : SEPH1
      vendor_id       : [0][0][0][0]
  Stream #0:1[0x2](eng): Audio: aac (LC) (mp4a / 0x6134706D), 48000 Hz, stereo, fltp, 183 kb/s (default)
    Metadata:
      creation_time   : 2023-05-22T07:05:20.000000Z
      handler_name    : Stereo AAC
      vendor_id       : [0][0][0][0]
  Stream #0:2[0x3](eng): Audio: ac3 (ac-3 / 0x332D6361), 48000 Hz, stereo, fltp, 224 kb/s (default)
    Metadata:
      creation_time   : 2023-05-22T07:05:58.000000Z
      handler_name    : Commentary
      vendor_id       : [0][0][0][0]
    Side data:
      audio service type: main
  Stream #0:3[0x4](eng): Subtitle: mov_text (tx3g / 0x67337874), 1440x1080, 0 kb/s (default)
    Metadata:
      creation_time   : 2023-05-22T07:05:58.000000Z
      handler_name    : SDH
  Stream #0:4[0x0]: Video: mjpeg (Progressive), yuvj420p(pc, bt470bg/unknown/unknown), 1000x1426, 90k tbr, 90k tbn (attached pic)

I'm working on getting a dev build onto my Roku and will post logs when I do

F0x1 added a commit to F0x1/jellyfin-roku that referenced this issue Dec 15, 2024
…ng issue on Roku

- Removed the line `m.LoadMetaDataTask.selectedSubtitleIndex = m.top.SelectedSubtitle` from onAudioIndexChange()
- Removed the line `m.LoadMetaDataTask.selectedAudioStreamIndex = m.top.audioIndex` from onSubtitleChange()
- These removals address a race condition causing video playback to fail when switching audio tracks

Fixes jellyfin#2059
@phagez
Copy link

phagez commented Dec 19, 2024

I have this same issue on at least one of my movies. I see that the fix has to do with a metadata race condition and possibly loading subtitles. I have also noticed that another of my movies cannot seem to change subtitles in the same way this movie wont change audio tracks, could they be the same issue or should I look into creating a bug report?

Also, how confident are we that this race condition really is the issue? Like the comment above even if I change the default audio track before playing the movie it still does not load the correct track for me, which im not sure fits the narrative of the fix above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants