Merge branch 'master' into 215-merge-conflicts

.github/workflows/auto-close-stale-pr.yml

@@ -15,9 +15,9 @@ jobs:
           days-before-issue-stale: -1
           days-before-issue-close: -1
           stale-pr-label: stale
-          stale-pr-message: "This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity."
-          close-pr-message: "This pull request has been closed because it has been inactive for 28 days. You may submit a new pull request if desired."
-          days-before-pr-stale: 21
-          days-before-pr-close: 7
+          stale-pr-message: "This pull request has been inactive for 30 days and will be automatically closed in 15 days if there is no further activity."
+          close-pr-message: "This pull request has been closed because it has been inactive for 45 days. You may submit a new pull request if desired."
+          days-before-pr-stale: 30
+          days-before-pr-close: 15
           exempt-draft-pr: true
           repo-token: ${{ secrets.JF_BOT_TOKEN }}

.github/workflows/automations.yml

@@ -10,7 +10,8 @@ on:
 
 jobs:
   project:
-    if: github.repository == 'jellyfin/jellyfin-roku'
+    # don't run job on forks and prevent job from running twice when a PR pushes a new commit
+    if: github.repository == 'jellyfin/jellyfin-roku' && github.event_name != 'pull_request' || github.repository == 'jellyfin/jellyfin-roku' && github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     name: Project board 📊
     runs-on: ubuntu-latest
     steps:
@@ -22,7 +23,8 @@ jobs:
           column: In progress
           repo-token: ${{ secrets.JF_BOT_TOKEN }}
   label:
-    if: github.repository == 'jellyfin/jellyfin-roku'
+    # don't run job on forks and prevent job from running twice when a PR pushes a new commit
+    if: github.repository == 'jellyfin/jellyfin-roku' && github.event_name != 'pull_request' || github.repository == 'jellyfin/jellyfin-roku' && github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     name: Labeling 🏷️
     runs-on: ubuntu-latest
     steps:

.github/workflows/build-dev.yml

@@ -6,10 +6,12 @@ on:
 
 jobs:
   dev:
+    # prevent job from running twice when a PR pushes a new commit
+    if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
-      - uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
+      - uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4
         with:
           node-version: "lts/*"
           cache: "npm"
@@ -19,7 +21,7 @@ jobs:
         run: npm run ropm
       - name: Build app
         run: npm run build
-      - uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # v4
+      - uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4
         with:
           name: Jellyfin-Roku-dev-${{ github.sha }}
           path: ${{ github.workspace }}/build/staging

.github/workflows/build-prod.yml

@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
-      - uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
+      - uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4
         with:
           node-version: "lts/*"
           cache: "npm"
@@ -23,7 +23,7 @@ jobs:
         run: npm run ropm
       - name: Build app for production
         run: npm run build-prod
-      - uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # v4
+      - uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4
         with:
           name: Jellyfin-Roku-v${{ env.newManVersion }}-${{ github.sha }}
           path: ${{ github.workspace }}/build/staging

.github/workflows/bump-version.yml

@@ -94,7 +94,7 @@ jobs:
           git add .
           git commit -m "Bump ${{ github.event.inputs.versionType }} version"
           git push --set-upstream origin "${{ env.newBranch }}"
-          gh pr create --title "Bump ${{ github.event.inputs.targetBranch }} branch to ${{ env.newVersion }}" --body "Bump version to prep for next release." --label ignore-changelog --base ${{ env.targetBranch }} 
+          gh pr create --title "Bump ${{ github.event.inputs.targetBranch }} branch to ${{ env.newVersion }}" --body "Bump version to prep for next release. Generated by `.github/workflows/bump-version.yml`" --label ignore-changelog --base ${{ env.targetBranch }} 
   minor:
     if: ${{ github.event.inputs.versionType == 'minor' }}
     runs-on: ubuntu-latest
@@ -161,7 +161,7 @@ jobs:
           git add .
           git commit -m "Bump ${{ github.event.inputs.versionType }} version"
           git push --set-upstream origin "${{ env.newBranch }}"
-          gh pr create --title "Bump ${{ github.event.inputs.targetBranch }} branch to ${{ env.newVersion }}" --body "Bump version to prep for next release." --label ignore-changelog --base ${{ env.targetBranch  }} 
+          gh pr create --title "Bump ${{ github.event.inputs.targetBranch }} branch to ${{ env.newVersion }}" --body "Bump version to prep for next release. Generated by `.github/workflows/bump-version.yml`" --label ignore-changelog --base ${{ env.targetBranch  }} 
       
   major:
     if: ${{ github.event.inputs.versionType == 'major' }}
@@ -231,5 +231,5 @@ jobs:
           git add .
           git commit -m "Bump ${{ github.event.inputs.versionType }} version"
           git push --set-upstream origin "${{ env.newBranch }}"
-          gh pr create --title "Bump ${{ github.event.inputs.targetBranch }} branch to ${{ env.newVersion }}" --body "Bump version to prep for next release." --label ignore-changelog --base ${{ env.targetBranch  }} 
+          gh pr create --title "Bump ${{ github.event.inputs.targetBranch }} branch to ${{ env.newVersion }}" --body "Bump version to prep for next release. Generated by `.github/workflows/bump-version.yml`" --label ignore-changelog --base ${{ env.targetBranch  }} 
       

.github/workflows/lint-brightscript.yml

@@ -0,0 +1,20 @@
+name: lint-brightscript
+on:
+  pull_request:
+    paths:
+      - "**/*.brs"
+      - "**/*.bs"
+
+jobs:
+  run:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@master
+      - uses: actions/setup-node@master
+        with:
+          node-version: "lts/*"
+          cache: "npm"
+      - run: npm ci
+      - run: npx ropm install
+      - run: npm run validate
+      - run: npm run check-formatting

.github/workflows/lint-json.yml

@@ -0,0 +1,23 @@
+name: lint-json
+on:
+  pull_request:
+    paths:
+      - "!docs/api/**"
+      - "**/*.json"
+
+jobs:
+  run:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Clone github repo
+        uses: actions/checkout@master
+      - uses: actions/setup-node@master
+        with:
+          node-version: "lts/*"
+          cache: "npm"
+      - name: Install npm dependencies
+        run: npm ci
+      - name: Install roku package dependencies
+        run: npx ropm install
+      - name: Validate JSON syntax
+        run: npm run lint-json

.github/workflows/lint-markdown.yml

@@ -0,0 +1,23 @@
+name: lint-markdown
+on:
+  pull_request:
+    paths:
+      - "**/*.md"
+
+jobs:
+  run:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Clone github repo
+        uses: actions/checkout@master
+      - uses: actions/setup-node@master
+        with:
+          node-version: "lts/*"
+          cache: "npm"
+      - name: Install npm dependencies
+        run: npm ci
+      - name: Install roku package dependencies
+        run: npx ropm install
+      - uses: xt0rted/markdownlint-problem-matcher@1a5fabfb577370cfdf5af944d418e4be3ea06f27 # v3
+      - name: Lint markdown files
+        run: npm run lint-markdown

.github/workflows/lint-spelling.yml

@@ -0,0 +1,22 @@
+name: lint-spelling
+on:
+  pull_request:
+    paths:
+      - "**/*.md"
+
+jobs:
+  run:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Clone github repo
+        uses: actions/checkout@master
+      - uses: actions/setup-node@master
+        with:
+          node-version: "lts/*"
+          cache: "npm"
+      - name: Install npm dependencies
+        run: npm ci
+      - name: Install roku package dependencies
+        run: npx ropm install
+      - name: Check markdown files for spelling errors
+        run: npm run lint-spelling

.github/workflows/lint-translation-files.yml

@@ -0,0 +1,25 @@
+name: lint-translation-files
+on:
+  pull_request:
+    paths:
+      - "locale/*/*.ts"
+
+jobs:
+  run:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Clone github repo
+        uses: actions/checkout@master
+      - name: Install xmllint and xmlstarlet using apt (from cache)
+        uses: awalsh128/cache-apt-pkgs-action@latest
+        with:
+          packages: libxml2-utils xmlstarlet
+      - name: Validate XML syntax
+        run: xmllint --noout ./locale/en_US/translations.ts
+      - name: Save output of duplicate check
+        run: echo "tsDuplicates=$(xmlstarlet sel -t -m '/TS/context/message/source' -c '.' -nl ./locale/en_US/translations.ts | sort | uniq -d | awk '{ printf "%s", $0 }')" >> $GITHUB_ENV
+      - name: Check for duplicates
+        run: xmlstarlet sel -t -m '/TS/context/message/source' -f -o ' ' -c '.' -nl ./locale/en_US/translations.ts | sort | uniq -d
+      - name: Duplicates found
+        if: env.tsDuplicates != ''
+        run: exit 1