Add rules, fix issues and cleanup #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1268
to
+1276
| foreach (var element in servicesList) | ||
| { | ||
| var service = Create(element); | ||
|
|
||
| if (service is not null) | ||
| { | ||
| deviceServices.Add(service); | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select Note
crobibero
requested changes
Nov 6, 2024
JPVenson
reviewed
Nov 8, 2024
Bond-009
reviewed
Nov 24, 2024
JPVenson
reviewed
Dec 8, 2024
| @@ -170,7 +219,7 @@ public static IEnumerable<string> BuildVideoHeader( | |||
| ";DLNA.ORG_FLAGS={0}", | |||
| DlnaMaps.FlagsToString(flagValue)); | |||
|
|
|||
| ResponseProfile mediaProfile = profile.GetVideoMediaProfile( | |||
| ResponseProfile? mediaProfile = profile.GetVideoMediaProfile( | |||
oddstr13
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
This looks like apply linting rules -> fix lints, in addition to nullability stuff and documentation (presumably linter-demanded).
I don't know the implications of Array.Empty<Type>() -> [], if any.
This is a rubber-stamp from my part, I've looked at all the changes, and nothing obvious popped out at me.
Visual inspection only, no testing done – but I did note that JPRM compiled it fine in CI.
| return name switch | ||
| return _disposed | ||
| ? throw new ObjectDisposedException(GetType().Name) | ||
| : name switch |
There was a problem hiding this comment.
Is this linter recommended?
I personally don't think this makes the code easier to read.
crobibero
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.