Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user device name entitlement #597

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

thornbill
Copy link
Member

Adds the user device name entitlement so we can access the actual device name instead of the generic name (i.e. "iPhone").

Note: we will need to follow the process described here to request this entitlement.

Fixes #590

@thornbill thornbill added the bug Something isn't working label Dec 29, 2024
@thornbill thornbill added this to the v1.6.0 milestone Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.97%. Comparing base (ac7f5c2) to head (7cb9bff).
Report is 27 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #597   +/-   ##
=======================================
  Coverage   59.97%   59.97%           
=======================================
  Files          47       47           
  Lines         947      947           
  Branches      189      187    -2     
=======================================
  Hits          568      568           
  Misses        344      344           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anthonylavado
Copy link
Member

This has been requested from Apple Developer Support. I'll let you know what their answer is when I get one.

@thornbill thornbill merged commit 2339cdc into jellyfin:master Jan 15, 2025
9 checks passed
@thornbill thornbill deleted the fix-device-name branch January 15, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Device Name not passed to Server
3 participants