Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device Name not passed to Server #590

Closed
markphillips100 opened this issue Dec 17, 2024 · 4 comments · Fixed by #597
Closed

Device Name not passed to Server #590

markphillips100 opened this issue Dec 17, 2024 · 4 comments · Fixed by #597
Labels
bug Something isn't working
Milestone

Comments

@markphillips100
Copy link

Describe the bug
Ipad device name is not coming through. App defaults to "iPad" which then causes clashes at server for concurrent ipad playback, especially when it comes to transcoding.

System (please complete the following information):

  • iOS Version: iPad OS 18.2
  • Jellyfin Expo version: 1.5
  • Jellyfin Server version: 10.10.3

To Reproduce
Install app on 2 ipads, signin on both, and check the devices list in Dashboard. Will only see one device.

Expected behavior
Should use the device name so that separate devices are registered at server.

Additional context
This code attempts to get the device name but must be coming back null and so the fallback modelName is being used. Perhaps this is due to a new privilege in ipad OS 18?

@thornbill
Copy link
Member

Confirmed. iOS 16+ requires an additional entitlement: https://docs.expo.dev/versions/latest/sdk/device/#devicedevicename

@thornbill thornbill added this to the v1.6.0 milestone Dec 19, 2024
@markphillips100
Copy link
Author

@thornbill I realise there is no due date on a 1.6 release but may I ask if there's some ball park date being considered?

@thornbill
Copy link
Member

I'm hoping for sometime in January if all goes well.

@markphillips100
Copy link
Author

That would be awesome. Thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants