Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Webpack with Vite #476

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Replace Webpack with Vite #476

merged 3 commits into from
Oct 3, 2023

Conversation

nielsvanvelzen
Copy link
Member

This PR removed Webpack in favor of Vite. The configuration is much simpler, there are way less dependencies, build times improve significantly and we get hot reload for the index.html file.

@nielsvanvelzen nielsvanvelzen marked this pull request as ready for review October 2, 2023 20:10
src/helpers.ts Outdated Show resolved Hide resolved
src/helpers.ts Outdated Show resolved Hide resolved
Copy link
Member

@ferferga ferferga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe ts-node, cross-env and source-map-loader are not necessary as well?

@nielsvanvelzen
Copy link
Member Author

nielsvanvelzen commented Oct 3, 2023

Yup and I also forgot css-loader, I probably made some error during the first rebase causing them to be added back.

@nielsvanvelzen nielsvanvelzen merged commit eac118e into master Oct 3, 2023
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the nvv-vite branch October 3, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants