Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize requested item fields #4341

Merged

Conversation

nielsvanvelzen
Copy link
Member

We currently have API requests all over the app but they all request a different set of item fields. This can cause issues if baseitemdto's are passed between various parts of the app.

Changes

  • Add ItemRepository, which for now holds a set of fields used by the app only
  • Update all API calls that currently request fields to use the new ItemRepository.itemFields

Issues

@nielsvanvelzen nielsvanvelzen added the refactor Improvements to code realiability, readability and quality label Dec 24, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.19.0 milestone Dec 24, 2024
@nielsvanvelzen nielsvanvelzen merged commit 832ab68 into jellyfin:master Dec 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improvements to code realiability, readability and quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants