Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when viewing audio now playing while using Emerald theme #4269

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix crash when viewing audio now playing while using Emerald theme #4269

merged 1 commit into from
Dec 5, 2024

Conversation

nielsvanvelzen
Copy link
Member

The emerald theme changes the defaultBackground to a drawable (is a color by default). Obviously can't use a drawable as color.

Changes

  • Hardcode the not_quite_black color in audio_now_playing_album_background instead of using the defaultBackground attribute

Issues

Fixes #4266

@nielsvanvelzen nielsvanvelzen added bug Something isn't working crash Bug causing app crashes labels Dec 5, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.18.1 milestone Dec 5, 2024
@nielsvanvelzen nielsvanvelzen merged commit 2fea546 into jellyfin:master Dec 5, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the emeral-theme-audio-playback branch December 5, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
bug Something isn't working crash Bug causing app crashes
Projects
None yet
Milestone
v0.18.1
Development

Successfully merging this pull request may close these issues.

[0.18.0] Music playback fails and causes the app to crash
2 participants
@nielsvanvelzen @crobibero