Add resolution codec check #3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/main/java/org/jellyfin/androidtv/util/profile/MediaCodecCapabilitiesTest.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/org/jellyfin/androidtv/util/profile/MediaCodecCapabilitiesTest.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/org/jellyfin/androidtv/util/profile/MediaCodecCapabilitiesTest.kt
Fixed
Show fixed
Hide fixed
MichaelRUSF
force-pushed
the
4k-resolution-check
branch
from
86b0190 to
567c992
Compare
nielsvanvelzen
requested changes
Sep 2, 2024
MichaelRUSF
force-pushed
the
4k-resolution-check
branch
2 times, most recently
from
9d1ff79 to
d7336d5
Compare
MichaelRUSF
force-pushed
the
4k-resolution-check
branch
from
d7336d5 to
73694ec
Compare
nielsvanvelzen
requested changes
Sep 5, 2024
app/src/main/java/org/jellyfin/androidtv/util/profile/MediaCodecCapabilitiesTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/MediaCodecCapabilitiesTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/MediaCodecCapabilitiesTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/ProfileHelper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/util/profile/ProfileHelper.kt
Outdated
Show resolved
Hide resolved
| var maxWidth = 0 | ||
| var maxHeight = 0 | ||
|
|
||
| for (info in mediaCodecList.codecInfos) { |
Check warning
Code scanning / detekt
The loop contains more than one break or continue statement. The code should be refactored to increase readability. Warning
MichaelRUSF
force-pushed
the
4k-resolution-check
branch
from
d6b7f3f to
1a36699
Compare
nielsvanvelzen
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new check to verify resolution support, ensuring compatibility with 1080p devices. The update involves changes to
MediaCodecCapabilitiesTest,ProfileHelper,ExoPlayerProfile, andPlaybackController, allowing playback options to be configured according to the codec's resolution capabilities of the device.Changes
getMaxResolutionmethod to return the maximum supported width and height.maxResolutionCodecProfileMediaTest.getMaxResolutionmax1080pProfileConditionsExoPlayerProfileto reflect changes in the handling of 1080p profiles and removes thedisable4KVideoparameter.!DeviceUtils.has4kVideoSupportcondition.