Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance AVC and High 10 Profile Support #3930

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

MichaelRUSF
Copy link
Contributor

Changes

This PR enhances the handling of AVC (H.264) and High 10 profile support. It introduces improvements to how codec profiles are evaluated and managed.

  1. Enhanced AVC Profile and level mapping:
    • Mapped AVC levels using CodecProfileLevel constants to align with ffprobe reporting format.
  2. Added lazy initialization for checks methods:
    • supportsAVC supportsAVCHigh10
  3. Updated codec profile & level conditions:
    • Removed h264VideoLevelProfileCondition & h264VideoProfileCondition, which had hard-coded data.
    • Added deviceAvcCodecProfile & deviceAvcLevelCodecProfiles to manage AVC codec profile and level conditions.

@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Aug 25, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.18.0 milestone Aug 25, 2024
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nielsvanvelzen nielsvanvelzen merged commit 50ef4a7 into jellyfin:master Aug 25, 2024
6 checks passed
@nielsvanvelzen nielsvanvelzen added the backportable Change may be backported to a point release (remove label once cherrypicked) label Aug 25, 2024
@MichaelRUSF MichaelRUSF deleted the avc-level-checks branch August 25, 2024 18:10
@nielsvanvelzen nielsvanvelzen modified the milestones: v0.18.0, v0.17.5 Sep 8, 2024
@nielsvanvelzen nielsvanvelzen removed the backportable Change may be backported to a point release (remove label once cherrypicked) label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants