-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken subtitles line wrapping #1346
Conversation
Apparently I did a mistake using the ReplacementSpan for outlining the text as it doesn't support line wrapping, so lets do it with a custom TextView :)
I haven't dug into the details of your implementation so I won't comment on that yet. But conceptually I'm a fan of having a custom textview for outlined text. This could be used to add outlines to other UI elements that need it, like the title/clock row in the playback overlay. Currently that can be difficult to read depending on what's on screen in a video. |
That's exactly what I thought while doing it. Also easy to add extras as outlining colour and so on if needed at some point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not tested this or the other PR but my preference goes to a custom view like this one does. I've done a quick initial review on the code.
app/src/main/java/org/jellyfin/androidtv/ui/shared/StrokeTextView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/shared/StrokeTextView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/shared/StrokeTextView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/shared/StrokeTextView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/shared/StrokeTextView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/shared/StrokeTextView.kt
Outdated
Show resolved
Hide resolved
Sorry, I did it on a hurry yesterday and didn't even checked the warnings (the reason I didn't marked anything as resolved), I just came to review what I did and is left to be done, but you was first. |
I tested it with some videos/subtitles that clipped before and it works well! |
Changes
Apparently I did a mistake using the ReplacementSpan for outlining the text as it doesn't support line wrapping, so lets remove it and do it with a custom TextView :)
Issues
#1303 broke subtitle line wrapping