Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport minimal core changes for new playback module #1229

Closed

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Oct 24, 2021

Nothing major changed in this PR, it's only small stuff that is not in the playback module. The only reason for this early backport is to make rebasing easier when any of these files change (especially the libs.versions.toml file).

Changes

  • Update kotlinx.coroutines to fix binary incompatibility
  • Add kotlinx.coroutines guava module for playback module MediaSessions
  • Add androidx.media2 session module for playback module MediaSessions
  • Fix formatting in PlaybackForwardingActivity
  • Fix typo in DeveloperPreferencesScreen

Issues

Part of #1057

- Update kotlinx.coroutines to fix binary incompatibility
- Add kotlinx.coroutines guava module for playback module MediaSessions
- Add androidx.media2 session module for playback module MediaSessions
- Fix formatting in PlaybackForwardingActivity
- Fix typo in DeveloperPreferencesScreen
@nielsvanvelzen
Copy link
Member Author

This PR is already outdated, will make a new one later

@nielsvanvelzen nielsvanvelzen deleted the playback-backport-deps branch October 28, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant