Hide video player controls by default

jellyfin · Oct 29, 2024 · 1062d7b · 1062d7b
1 parent e7738c7
commit 1062d7b
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 5 deletions.
diff --git a/app/src/main/java/org/jellyfin/androidtv/ui/playback/CustomPlaybackOverlayFragment.java b/app/src/main/java/org/jellyfin/androidtv/ui/playback/CustomPlaybackOverlayFragment.java
@@ -121,11 +121,11 @@ public class CustomPlaybackOverlayFragment extends Fragment implements LiveTvGui
     private AudioManager mAudioManager;
 
     private boolean mFadeEnabled = false;
-    private boolean mIsVisible = true;
+    private boolean mIsVisible = false;
     private boolean mPopupPanelVisible = false;
     private boolean navigating = false;
 
-    private LeanbackOverlayFragment leanbackOverlayFragment;
+    protected LeanbackOverlayFragment leanbackOverlayFragment;
 
     private final Lazy<org.jellyfin.sdk.api.client.ApiClient> api = inject(org.jellyfin.sdk.api.client.ApiClient.class);
     private final Lazy<MediaManager> mediaManager = inject(MediaManager.class);
@@ -294,6 +294,9 @@ public void onScrollChanged(ObservableHorizontalScrollView scrollView, int x, in
         // start playing
         playbackControllerContainer.getValue().getPlaybackController().play(startPos);
         leanbackOverlayFragment.updatePlayState();
+
+        // Set initial skip overlay state
+        binding.skipOverlay.setSkipUiEnabled(!mIsVisible && !mGuideVisible && !mPopupPanelVisible);
     }
 
     @Override
@@ -1209,7 +1212,6 @@ public void setSecondaryTime(long time) {
 
     public void setFadingEnabled(boolean value) {
         mFadeEnabled = value;
-//        if (!mIsVisible) requireActivity().runOnUiThread(this::show);
         if (mFadeEnabled) {
             startFadeTimer();
         } else {

diff --git a/app/src/main/java/org/jellyfin/androidtv/ui/playback/PlaybackController.java b/app/src/main/java/org/jellyfin/androidtv/ui/playback/PlaybackController.java
@@ -1093,7 +1093,7 @@ public void onPlaybackSpeedChange(float newSpeed) {
     @Override
     public void onPrepared() {
         if (mPlaybackState == PlaybackState.BUFFERING) {
-            if (mFragment != null) mFragment.setFadingEnabled(true);
+            if (mFragment != null) mFragment.leanbackOverlayFragment.setShouldShowOverlay(false);
 
             mPlaybackState = PlaybackState.PLAYING;
             mCurrentTranscodeStartTime = mCurrentStreamInfo.getPlayMethod() == PlayMethod.Transcode ? Instant.now().toEpochMilli() : 0;

diff --git a/app/src/main/java/org/jellyfin/androidtv/ui/playback/overlay/LeanbackOverlayFragment.java b/app/src/main/java/org/jellyfin/androidtv/ui/playback/overlay/LeanbackOverlayFragment.java
@@ -3,7 +3,10 @@
 import static org.koin.java.KoinJavaComponent.inject;
 
 import android.os.Bundle;
+import android.view.View;
 
+import androidx.annotation.NonNull;
+import androidx.annotation.Nullable;
 import androidx.leanback.app.PlaybackSupportFragment;
 
 import org.jellyfin.androidtv.ui.playback.CustomPlaybackOverlayFragment;
@@ -36,6 +39,13 @@ public void onCreate(Bundle savedInstanceState) {
         playerGlue.setHost(new CustomPlaybackFragmentGlueHost(this));
     }
 
+    @Override
+    public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
+        super.onViewCreated(view, savedInstanceState);
+
+        super.hideControlsOverlay(false);
+    }
+
     public void initFromView(CustomPlaybackOverlayFragment customPlaybackOverlayFragment) {
         playerGlue.setInitialPlaybackDrawable();
         playerAdapter.setMasterOverlayFragment(customPlaybackOverlayFragment);

diff --git a/app/src/main/res/layout/vlc_player_interface.xml b/app/src/main/res/layout/vlc_player_interface.xml
@@ -64,7 +64,8 @@
         android:layout_gravity="center_horizontal|top"
         android:layout_marginHorizontal="40dp"
         android:layout_marginTop="20dp"
-        android:clickable="false">
+        android:clickable="false"
+        android:visibility="gone">
 
         <org.jellyfin.androidtv.ui.AsyncImageView
             android:id="@+id/item_logo"