Update jellyfin-sdk-kotlin to v1.6.1 #1506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
requested changes
Nov 5, 2024
nielsvanvelzen
requested changes
Nov 5, 2024
app/src/main/java/org/jellyfin/mobile/player/source/MediaSourceResolver.kt
Outdated
Show resolved
Hide resolved
|
Any chance of getting this reviewed again @nielsvanvelzen ? It would be nice to start generating builds from the updated sdk... |
nielsvanvelzen
previously approved these changes
Dec 17, 2024
|
Would someone be so kind as to trigger the build and test workflows on this PR? |
|
GH does not let me trigger the builds so the pull request probably needs to be rebased or have master merged into it. |
Fix build errors and add API authorization headers to exoplayer since the access token is no longer passed via URL for Android Auto. See jellyfin/jellyfin-sdk-kotlin#871
jakobkukla
force-pushed
the
sdk-update
branch
from
2bd932d to
ee40bcf
Compare
|
rebased on master. I think you should be able to trigger the build now @nielsvanvelzen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated SDK version and fixed build errors.
Also added the API authorization header to exoplayer since the access token is no longer passed via URL for Android Auto (see jellyfin/jellyfin-sdk-kotlin#871).
I have tested the Android Auto functionality and it seems to work fine. The only thing I cannot test and suspect that may not work is casting. Not sure how I would add the header there since CastPlayer cannot use a DataSource.Factory. In google/ExoPlayer#4760 they claim that the receiver app is responsible for authentication. Not sure if this is implemented in jellyfin/jellyfin-chromecast though.