Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor serialization into own class #373

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Conversation

LordMike
Copy link
Collaborator

@LordMike LordMike commented Apr 15, 2021

#360

I've refactored the serialization into a new ITMDbSerializer interface. This change removes all Newtonsoft.Json from all API surfaces..

  • The constructor will no longer take a JsonSerializer
  • The Newtonsoft.Json dependency is hidden, so it is no longer transient
  • There is a TMDbJsonSerializer.Instance which has the internal serializer

@LordMike LordMike merged commit 08e7544 into master Apr 15, 2021
@LordMike LordMike deleted the feature/serializer-refactor branch April 15, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant