Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Admin Dashboard - User Passwords #1312

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Nov 12, 2024

Summary

Instead of creating a new view, I added an optional init to the resetUserPasswordViewModel and resetUserPasswordView to allow it to be init using a user that was NOT the current device user. Then, I moved both of these to be modal since they're password reset forms (forms being modal?). Not that I think that's a requirement but more in line with other edit screens.

I've tested that this works for both the current user and another server user. The benefit to this approach is a single ViewModel and also allowing changes to this view in a single location for a more cohesive feel.

The only liberty I took with this (besides changing to this to modal) is I hide the current password field for Server Users since it's likely a password reset on their behalf. That is, you're approaching as an admin so you don't have their current password to reset so there is no reason for the field IMO.

Screenshot

UserView UserView Screenshot
Server User Password Server User Password Screenshot
Device User Password Device User Password Screenshot

@JPKribs
Copy link
Member Author

JPKribs commented Nov 14, 2024

Any idea what I am doing wrong? I haven't changed anything on my end, it builds locally, I'm on xcode 16.1 but I've been getting this issue about 70% of the time:

Screenshot 2024-11-14 at 09 48 58

If I select 'Retry' there is a 50/50 chance it fixes itself. I don't know if this is a github issue or a me issue.

@LePips
Copy link
Member

LePips commented Nov 14, 2024

Oh, that's due to Xcode 16 being removed from the macos-14 image.

actions/runner-images#10703

@JPKribs
Copy link
Member Author

JPKribs commented Nov 14, 2024

That looks like it did it! Thank you @LePips!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants