Store authentication data in cookies #154
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Adding a fallback to extract cookies would certainly be possible. I'm actually planning to soon go the other way around and inject the credentials into the webapp from the Android app, which cookies would make a lot easier too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by jellyfin/jellyfin-web#2481
Changes
UserIdandAccessTokenare stored in cookies ifEnableAutoLoginisfalse.At current moment, this PR breaks Android app here.☺️ , we can (? @Maxr1998 ) add reading of cookies if
App retrieves credentials from
localStorage, butUserIdandAccessTokenare now in the cookies, and it crashes.If storing credentials in the cookies is good enough
UserIdandAccessTokenfromlocalStorageare empty. In this case we will have backward compatibility.Also, I'm not sure about Tizen 2.3/2.4: they use WebKit and I don't know if they support session cookies for
file:protocol.