Skip to content

Commit

Permalink
v1.2.4-rc0
Browse files Browse the repository at this point in the history
  • Loading branch information
jeikabu committed Jan 14, 2020
1 parent fedd5b0 commit 0921474
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 33 deletions.
4 changes: 2 additions & 2 deletions nng.NETCore/nng.NETCore.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
<!-- Including assembly as part of runtimes/ so don't want it placed in lib/ -->
<IncludeBuildOutput>false</IncludeBuildOutput>
<PackageId>Subor.nng.NETCore</PackageId>
<PackageVersion>1.2.3-rc0</PackageVersion>
<Version>1.2.3.0</Version>
<PackageVersion>1.2.4-rc0</PackageVersion>
<Version>1.2.4.0</Version>
<!-- Needed to avoid `error NU5128` when running `dotnet pack`.
Assemblies for targetted frameworks are in runtimes/ instead of lib/ or ref/
See: https://docs.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu5128#scenario-2
Expand Down
4 changes: 2 additions & 2 deletions nng.Shared/nng.Shared.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@

<PropertyGroup>
<PackageId>Subor.nng.NETCore.Shared</PackageId>
<PackageVersion>1.2.3-rc0</PackageVersion>
<Version>1.2.3.0</Version>
<PackageVersion>1.2.4-rc0</PackageVersion>
<Version>1.2.4.0</Version>

<PackageOutputPath>../bin/$(Configuration)</PackageOutputPath>
</PropertyGroup>
Expand Down
28 changes: 0 additions & 28 deletions tests/BasicTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,33 +12,5 @@ namespace nng.Tests
[Collection("nng")]
public class BasicTests
{
[Fact]
[Trait(Traits.PlatformName, Traits.PlatformWindows)]
public void WindowsOnlyTestsFailonPosix()
{
switch (Environment.OSVersion.Platform)
{
case PlatformID.Unix:
case PlatformID.MacOSX:
Assert.True(false);
break;
}
}

[Fact]
[Trait(Traits.PlatformName, Traits.PlatformPosix)]
public void PosixOnlyTestsFailonWindows()
{
switch (Environment.OSVersion.Platform)
{
case PlatformID.Unix:
case PlatformID.MacOSX:
break;

default:
Assert.True(false);
break;
}
}
}
}
2 changes: 1 addition & 1 deletion tests/Util.cs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public static string GetDialUrl(IListener listener, string url)
port = (ushort)System.Net.IPAddress.NetworkToHostOrder((short)addr.s_in6.sa_port);
break;
default:
Assert.True(false);
Assert.True(false, addr.s_family.ToString());
break;
}
url = url.Substring(0, url.Length - 1) + port;
Expand Down

0 comments on commit 0921474

Please sign in to comment.