Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macOS APIs to get preferred localization and keep defaults as fallback #27

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

sdassow
Copy link
Contributor

@sdassow sdassow commented Nov 20, 2024

Newer versions of macOS allow to set a language per application instead of only system wide.
This currently affects Fyne, and is part of this issue: fyne-io/fyne#5277

The suggested solution is to use the macOS API instead of just the defaults command.

@sdassow
Copy link
Contributor Author

sdassow commented Nov 20, 2024

Going to add the plural version as well...

@sdassow sdassow changed the title Use macos APIs to get preferred localization and keep defaults as fallback Use macOS APIs to get preferred localization and keep defaults as fallback Nov 20, 2024
@andydotxyz
Copy link
Contributor

@jeandeaual do you need anything else added to this PR to allow the workflow to run or a review?

My apologies for the prod on Simon's behalf.

@jeandeaual
Copy link
Owner

Apologies for the delayed response, and thank for your patience.

Overall, this looks great to me.
I did notice that the API returns different locales compared to the system-wide ones, and it doesn't include a region (at least in my case), but this shouldn't be an issue.

@sdassow The CI/CD pipeline was is a bit out of date and failed during setup. Could you please rebase your branch on master and push it again?

@jeandeaual jeandeaual merged commit 75469e9 into jeandeaual:master Dec 4, 2024
23 checks passed
@jeandeaual
Copy link
Owner

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants