Create Feed Version enum class

jdecool · May 29, 2017 · 2c2a6f9 · 2c2a6f9
1 parent cf8ab0c
commit 2c2a6f9
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 8 deletions.
diff --git a/src/Versions.php b/src/Versions.php
@@ -0,0 +1,12 @@
+<?php
+
+namespace JDecool\JsonFeed;
+
+final class Versions
+{
+    const VERSION_1 = 'https://jsonfeed.org/version/1';
+
+    private function __construct()
+    {
+    }
+}
diff --git a/src/Writer/RendererFactory.php b/src/Writer/RendererFactory.php
@@ -3,11 +3,11 @@
 namespace JDecool\JsonFeed\Writer;
 
 use InvalidArgumentException;
+use JDecool\JsonFeed\Versions;
 
 class RendererFactory
 {
-    const VERSION_1 = '1.0';
-
+    /** @var array */
     private $renderers;
 
     /**
@@ -24,14 +24,14 @@ public function __construct()
      * @param string $version
      * @return Version1\Renderer
      */
-    public function createRenderer($version = self::VERSION_1)
+    public function createRenderer($version = Versions::VERSION_1)
     {
         if (isset($this->renderers[$version])) {
             return $this->renderers[$version];
         }
 
         switch ($version) {
-            case self::VERSION_1:
+            case Versions::VERSION_1:
                 return new Version1\Renderer();
         }
 

diff --git a/src/Writer/Version1/Renderer.php b/src/Writer/Version1/Renderer.php
@@ -8,19 +8,18 @@
 use JDecool\JsonFeed\Feed;
 use JDecool\JsonFeed\Hub;
 use JDecool\JsonFeed\Item;
+use JDecool\JsonFeed\Versions;
 use JDecool\JsonFeed\Writer\RendererInterface;
 
 class Renderer implements RendererInterface
 {
-    const VERSION_URL = 'https://jsonfeed.org/version/1';
-
     /**
      * {@inheritdoc}
      */
     public function render(Feed $feed)
     {
         $result = [
-            'version' => self::VERSION_URL,
+            'version' => Versions::VERSION_1,
             'title' => $feed->getTitle(),
         ];
 

diff --git a/test/Writer/RendererFactoryTest.php b/test/Writer/RendererFactoryTest.php
@@ -3,6 +3,7 @@
 namespace JDecool\Test\JsonFeed\Writer;
 
 use JDecool\JsonFeed\Feed;
+use JDecool\JsonFeed\Versions;
 use JDecool\JsonFeed\Writer\RendererFactory;
 use PHPUnit\Framework\TestCase;
 
@@ -20,7 +21,7 @@ public function testCreateVersion1Renderer()
     {
         $factory = new RendererFactory();
 
-        $renderer = $factory->createRenderer(RendererFactory::VERSION_1);
+        $renderer = $factory->createRenderer(Versions::VERSION_1);
         $this->assertInstanceOf('JDecool\JsonFeed\Writer\Version1\Renderer', $renderer);
     }