Allow packaging with bdist_egg #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Versioneer, bdist_egg gets broken down into distutils/install_lib and then build_py (see https://github.com/jcrist/skein/blob/master/versioneer.py#L1526-L1539). Currently none of the cmdclasses capture this, so the Java element of this project isn't built when running with bdist_egg; this patch fixes that.
|
Hey @jcrist would it be possible to have a peek at this? We're hoping to use Skein but stuck with using eggs internally, so this is a required change for us. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Versioneer, bdist_egg gets broken down into distutils/install_lib and then build_py (see https://github.com/jcrist/skein/blob/master/versioneer.py#L1526-L1539). Currently none of the cmdclasses capture this, so the Java element of this project isn't built when running with bdist_egg; this patch fixes that.