Period header #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this be merged? |
|
bump |
| @@ -46,8 +46,9 @@ Currently, Rack::Attack::RateLimit can only be configured to return rate limit h | |||
|
|
|||
| Rate limit headers are: | |||
|
|
|||
| * 'X-RateLimit-Limit' - The total number of requests allowed. | |||
| * 'X-RateLimit-Remaining' - The number of remaining requests. | |||
| * 'X-Rate-Limit-Limit' - The total number of requests allowed. | |||
There was a problem hiding this comment.
What is the reason for changing the header name? Merging this would require a major version bump.
|
@sandelius sorry for the late reply. @eksoverzero this needs to be rebased against master, as their were changes made since the PR was made that introduced merge conflicts. |
added 2 commits
November 12, 2014 21:28
Conflicts: README.md lib/rack/attack/rate-limit.rb spec/rack/attack/rate-limit_spec.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added X-Rate-Limit-Period headers.
This is in preparation for the changes in the 'reset_header' branch that addresses #2
I will pull request that only when I can figure out a proper test for it