Enhance app messaging (nebari-dev#368)

* added more relevant error handling and messaging * added index js/css * Added vscode to .gitingore file * removed vscode from .gitignore, put them in .gitignore_global * removed extra line in .gitignore * removed commented out import * fixing linting errors * more linting fixes * removed a test * made updates to end to end test * updated code as per PR review comments * added index.js, removed comment --------- Co-authored-by: Kilian Berres <[email protected]>
jbouder · Jul 2, 2024 · b22fe3c · b22fe3c
1 parent 6b7f241
commit b22fe3c
Show file tree

Hide file tree

Showing 12 changed files with 970 additions and 226 deletions.
diff --git a/jhub_apps/static/css/index.css b/jhub_apps/static/css/index.css
diff --git a/jhub_apps/static/js/index.js b/jhub_apps/static/js/index.js
diff --git a/jhub_apps/tests/tests_e2e/test_integration.py b/jhub_apps/tests/tests_e2e/test_integration.py
@@ -1,9 +1,9 @@
 import re
 import uuid
 
-import pytest
-import structlog
-from playwright.sync_api import Playwright, expect
+import pytest # type: ignore
+import structlog # type: ignore
+from playwright.sync_api import Playwright, expect # type: ignore
 
 from jhub_apps.hub_client.utils import is_jupyterhub_5
 from jhub_apps.spawner.types import Framework
@@ -89,8 +89,8 @@ def create_app(
     logger.info("Creating App")
     page.get_by_role("button", name="Create App").click()
     logger.info("Fill App display Name")
-    page.get_by_label("Name *").click()
-    page.get_by_label("Name *").fill(app_name)
+    page.get_by_label("*Name").click()
+    page.get_by_label("*Name").fill(app_name)
     logger.info("Select Framework")
     page.locator("id=framework").click()
     page.get_by_role("option", name="Panel").click()