Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fault Tolerance multiple metrics provider test #318

Merged

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Dec 5, 2024

Fixes tests introduced by #316, as just regular executions were working, thanks to default server config.
Changes in here are to fix the test logic in order to work with Bootable JAR too.

TL; DR;

Other than fixing the multiple metrics provider test, I've refactored server config classes to isolate OTel subsystem

Verification job runs:

  • [Regular execution]: eap-8.x-microprofile-testsuite - 1163
  • [Bootable JAR execution] eap-8.x-microprofile-testsuite-bootable - 636

Please make sure your PR meets the following requirements:

  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is formatted, imports ordered, code compiles and tests are passing
  • Link to the passing job is provided
  • Code is self-descriptive and/or documented
  • Description of the tests scenarios is included (see Update PR template to include TPG stuff #46)

@fabiobrz fabiobrz force-pushed the fix.MultipleMetricsExtensionTest branch 3 times, most recently from 1c12a81 to 4805c7e Compare December 6, 2024 17:35
Split OTel related configuration APIs to OpenTelemetryServerCOnfiguration
@fabiobrz fabiobrz force-pushed the fix.MultipleMetricsExtensionTest branch from 4805c7e to c73d6f9 Compare December 10, 2024 09:58
@fabiobrz fabiobrz requested review from marekkopecky and jbliznak and removed request for marekkopecky December 16, 2024 13:26
@jbliznak
Copy link
Contributor

LGTM, thanks Fabio 👍

@jbliznak jbliznak merged commit 22655bc into jboss-eap-qe:master Dec 16, 2024
4 of 8 checks passed
@fabiobrz
Copy link
Member Author

LGTM, thanks Fabio 👍

Thank you indeed for the quick review, @jbliznak!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants