Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ofx converter, checknum numeric and check balance. #58

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

- have CHECKNUM alphanumeric as specified by OFX 2.2
- suppress or determine a correct balance depending on DTEND and DTASOF
@coveralls
Copy link

Pull Request Test Coverage Report for Build 123

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-66.8%) to 0.0%

Totals Coverage Status
Change from base Build 116: -66.8%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 8, 2020

Pull Request Test Coverage Report for Build 169

  • 21 of 22 (95.45%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 67.115%

Changes Missing Coverage Covered Lines Changed/Added Lines %
beancount_import/source/venmo_sanitize.py 0 1 0.0%
Totals Coverage Status
Change from base Build 162: 0.07%
Covered Lines: 4562
Relevant Lines: 6590

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 123

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-66.8%) to 0.0%

Totals Coverage Status
Change from base Build 116: -66.8%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@gpaulissen gpaulissen closed this Jun 9, 2020
@gpaulissen gpaulissen reopened this Jun 9, 2020
@gpaulissen
Copy link
Author

Due to ofxstatement 0.6.5 not available on PyPi yesterday, some checks failed. Now ofxstatement 0.6.5 is available on PyPi so it should work.

@gpaulissen
Copy link
Author

The checks seem to fail due to beancount-import issues, not due to the latest changes.

@gpaulissen
Copy link
Author

After improving the code coverage everything seems right.

@Zburatorul
Copy link
Collaborator

@gpaulissen , any interest in getting this over the line?

@Zburatorul
Copy link
Collaborator

Looks like you may need to rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants