This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Set correct count after unioning two bloom filters #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sets the correct count for union, but will need to also have it set for intersection in this case. I can take a look at adding this soon. Another possibility is removing the count entirely and moving to a more pressure based system for growing the filter that isn't exposed to the API. Let me think about this some more. |
|
I added the correct count in the intersection method as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After unioning two bloom filters, the count of the resulting bloom filter was set to 0. I updated the union method to update the self.count of the result as well.