Do not change existing hash password #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code changes the hash password in the account in case a different password is given than was stored in the account. I can't see why that would be useful as the entire use of a password is then gone. I changed the code to check whether a hash password in the account already exists. If it does NOT exist and we supply a new hash password, it is set to the given hash password.
|
How would you be able to change the password if it is already set? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code changes the hash password in the account in case a different password is given than was stored in the account. I can't see why that would be useful as the entire use of a password is then gone. I changed the code to check whether a hash password in the account already exists. If it does NOT exist and we supply a new hash password, it is set to the given hash password.