Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin refactor #118

Merged
merged 13 commits into from
Dec 31, 2023
Merged

Kotlin refactor #118

merged 13 commits into from
Dec 31, 2023

Conversation

zugazagoitia
Copy link
Member

Closes #111

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (e679290) 92.57% compared to head (e4cd339) 92.20%.

Files Patch % Lines
.../main/kotlin/io/javalin/community/ssl/SSLConfig.kt 82.08% 2 Missing and 10 partials ⚠️
.../main/kotlin/io/javalin/community/ssl/SSLPlugin.kt 92.59% 1 Missing and 1 partial ⚠️
...n/kotlin/io/javalin/community/ssl/util/SSLUtils.kt 91.66% 0 Missing and 2 partials ⚠️
.../main/kotlin/io/javalin/community/ssl/TLSConfig.kt 97.91% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #118      +/-   ##
============================================
- Coverage     92.57%   92.20%   -0.38%     
+ Complexity       77       73       -4     
============================================
  Files             7        7              
  Lines           283      218      -65     
  Branches         20       24       +4     
============================================
- Hits            262      201      -61     
+ Misses           19        4      -15     
- Partials          2       13      +11     
Flag Coverage Δ
integrationTests ?
unitTests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zugazagoitia zugazagoitia merged commit 4af9952 into dev Dec 31, 2023
26 of 28 checks passed
@zugazagoitia zugazagoitia deleted the kotlin-refactor branch January 3, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support javalin 6.0
1 participant