Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: definition of the WA Field scoring system. #86

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

jatkinson1000
Copy link
Owner

Fixes #85.

Incorrect ranges in the definition of the WA Field scoring system making targets (and therefore predicted scores) too large.
Spotted by @TomHall2020.

@jatkinson1000 jatkinson1000 added the bug Something isn't working label Mar 10, 2024
@jatkinson1000 jatkinson1000 self-assigned this Mar 10, 2024
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.47%. Comparing base (8f45558) to head (cac7193).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files          28       28           
  Lines        1505     1505           
=======================================
  Hits         1467     1467           
  Misses         38       38           
Files Coverage Δ
archeryutils/handicaps/handicap_scheme.py 97.22% <ø> (ø)
archeryutils/handicaps/tests/test_handicaps.py 100.00% <ø> (ø)

@jatkinson1000 jatkinson1000 merged commit e59da86 into main Mar 10, 2024
12 checks passed
@jatkinson1000 jatkinson1000 deleted the wafield-bugfix branch March 10, 2024 13:27
@jatkinson1000 jatkinson1000 mentioned this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in definition of WA Field target
1 participant