Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting #44

Merged
merged 27 commits into from
Sep 3, 2023
Merged

Linting #44

merged 27 commits into from
Sep 3, 2023

Conversation

jatkinson1000
Copy link
Owner

Addresses #28

Clean up code to address pylint errors, in some cases leading to notable refactors => merge as rebase.

@jatkinson1000 jatkinson1000 self-assigned this Sep 2, 2023
@jatkinson1000 jatkinson1000 added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 2, 2023
@jatkinson1000
Copy link
Owner Author

Refactor of handicap params leads to failure of tests due to type hinting not being fully available in python <3.9
See here.

Since 3.7 has reached end of life, and 3.8 has 1 year left this could perhaps be solved by updating rthe supported versions for this library to 3.9+

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #44 (9b51ff5) into main (bbacf50) will increase coverage by 5.02%.
Report is 1 commits behind head on main.
The diff coverage is 91.93%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   90.03%   95.06%   +5.02%     
==========================================
  Files          21       22       +1     
  Lines        1114     1216     +102     
==========================================
+ Hits         1003     1156     +153     
+ Misses        111       60      -51     
Files Changed Coverage Δ
...utils/classifications/agb_field_classifications.py 98.50% <ø> (ø)
.../classifications/agb_old_indoor_classifications.py 97.91% <ø> (ø)
...utils/classifications/tests/test_agb_old_indoor.py 100.00% <ø> (ø)
archeryutils/load_rounds.py 74.62% <ø> (ø)
archeryutils/rounds.py 100.00% <ø> (ø)
archeryutils/handicaps/handicap_functions.py 82.74% <80.13%> (+15.03%) ⬆️
...cheryutils/classifications/classification_utils.py 90.38% <94.11%> (+1.70%) ⬆️
archeryutils/__init__.py 100.00% <100.00%> (ø)
...tils/classifications/agb_indoor_classifications.py 98.43% <100.00%> (+1.42%) ⬆️
...ils/classifications/agb_outdoor_classifications.py 99.15% <100.00%> (+3.28%) ⬆️
... and 8 more

@jatkinson1000 jatkinson1000 linked an issue Sep 3, 2023 that may be closed by this pull request
@jatkinson1000 jatkinson1000 merged commit df7cfa2 into main Sep 3, 2023
@jatkinson1000 jatkinson1000 deleted the linting branch September 3, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get CI green (address pylint)
1 participant