Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added quick Python demo for users that may not have Jupyter. #34

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jstayco
Copy link

@jstayco jstayco commented Mar 30, 2024

Nothing more than the title says. This is a quick script I threw together for those that may not have Jupyter available. I have not tested this script, but I didn't see anywhere here to share my gist. So I thought I could put it here as a PR if people are up for testing it. If this is an inappropriate location, please feel free to close it and I can share the gist somewhere else if preferred.

@jasonppy
Copy link
Owner

jasonppy commented Apr 2, 2024

Thank you so much! Will test it soon

@iceisfun
Copy link

iceisfun commented Apr 2, 2024

Having a python script exec sudo commands seems outside the bounds of what should be an "example", should the setup instructions be outside of the script?

@arthurwolf arthurwolf mentioned this pull request Apr 3, 2024
@jstayco
Copy link
Author

jstayco commented Apr 5, 2024

Having a python script exec sudo commands seems outside the bounds of what should be an "example", should the setup instructions be outside of the script?

Sorry for the radio silence on this one. I should have time to look at it tomorrow or this weekend. I agree that sudo commands may be a bit much, but I was trying to make as much of a turnkey solution as possible so users had an easy entrypoint to just run a thing and have it do stuff without having to worry about complicated setups and instructions.

I'll test it out this weekend and try to get it in better shape especially on macOS. Once I get it there, I'll add a skip install option for the users that don't want that and I'll see about auto detecting if the packages are already present before trying to run the install, so hopefully that can autoskip where it makes sense.

@jasonppy jasonppy self-assigned this Apr 5, 2024
Still seeing errors with audiocraft in data/tokenizer.py on macOS. Also, seeing an error with MFA corpus file not being found.
inference_tts.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants