Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add deprecate note for topology plugins #2523

Merged
merged 1 commit into from
Nov 14, 2024
Merged

chore: add deprecate note for topology plugins #2523

merged 1 commit into from
Nov 14, 2024

Conversation

04kash
Copy link
Member

@04kash 04kash commented Nov 12, 2024 •
edited
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7eceb8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@04kash 04kash requested review from kim-tsao and removed request for Fortune-Ndlovu and its-mitesh-kumar November 12, 2024 16:05
@04kash 04kash changed the title chore: add deprecate for topology plugins chore: add deprecate note for topology plugins Nov 12, 2024
ciiay
ciiay approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@ciiay ciiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you.

@openshift-ci openshift-ci bot added the lgtm label Nov 13, 2024
@openshift-ci openshift-ci bot removed the lgtm label Nov 13, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

christoph-jerolimov
christoph-jerolimov approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@openshift-ci openshift-ci bot added the lgtm label Nov 14, 2024
@christoph-jerolimov christoph-jerolimov removed their assignment Nov 14, 2024
@christoph-jerolimov christoph-jerolimov merged commit fea868c into janus-idp:main Nov 14, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciiay ciiay ciiay approved these changes

@christoph-jerolimov christoph-jerolimov christoph-jerolimov approved these changes

@debsmita1 debsmita1 Awaiting requested review from debsmita1 debsmita1 is a code owner

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta divyanshiGupta is a code owner

@kim-tsao kim-tsao Awaiting requested review from kim-tsao

Assignees

@ciiay ciiay

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@04kash @christoph-jerolimov @ciiay