-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load via PINF JS Loader & minor changes #11
base: master
Are you sure you want to change the base?
Conversation
By the way. Awesome job on structuring and coding this project. It was done very future-proof. It required only minimal changes. |
…cate CSS files as they are part of widget now
Got bundle generation working as part of build and publishing to github pages. Check it out: http://fireconsole.github.io/harviewer/ Still some fixes but its working :) So anyone can now clone the harviewer, make changes, publish to gihub pages and other people can embed the component that was published in their tooling conflict free by pulling it directly from github pages. Will publish more info on embedding as part of component. |
http://fireconsole.github.io/harviewer/ now loads an optimized widget. One bug left for Firefox (works on Google Chrome) and will then work on widget embedding example. |
All done. See: http://fireconsole.github.io/harviewer/ The I'll be working on an API for the widget so it can be integrated into tooling without the full UI. I am looking to integrate this into fireconsole as a renderer. You will be able to fire a HAR URI at fireconsole and it will load a mapped viewer to display it. This will work for all data objects. |
All dependencies should be published. You should be able to clone this now on your own branch and run So any contributor can now preview changes in issues by publishing their branch to github pages. |
Working on using the component within fireconsole now. |
FYI: the fireconsole widget is now deployed as part of the devcomp.io instances and I have updated firebug.io: http://fireconsole-widget-console.firebug.io/ As I push changes to this stack now (like dynamically loading the harviewer) I will keep firebug.io updated until I eventually circle back to loading fireconsole as a devtools/firebug extension where the source loads from online or the local system sources. At that point we can take a serious look at the composition of firebug and see if we can not make much of it portable in this fashion and thus available for embedding in third party tools. |
I hope to, later this year, fix this patch to get the bundling working again. |
I ported the harviewer to run on my JS loader and only needed to make a few minor changes to get things working.
Everything should still work as before using requirejs but now also works via PINF.
I am using this to auto-bundle the viewer to embed it in other tooling. I'll be tweaking it to complete it as a standalone component, add bundle generation via PINF to the build process and document things more.
This will not run yet as I have to publish some PINF upstream dependencies but once that is done anyone will be able to install the nodejs dev server and work on the viewer using the requirejs or pinf loaders.
I am submitting this now for initial review and will send more patches to complete it.
I am looking forward to discussing this more. With this, we are one step closer to scraping JS modules from the Firebug source and use it in other tooling as I am now doing with this port. I'll show you how I have embedded the har viewer and am using some domplate reps from it in my new fireconsole project.