Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) feat: initial ui extension framework #3891

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Oct 28, 2024

Describe Your Changes

UIManager class that manages different UI components, allowing registration and retrieval based on component type. The components are categorized by a UIComponent enum

  • RightPanelTabItem
  • InputChatBox

Example use on extension

  • Add new tab for right panel tab component
import { UIManager } from '@janhq/core'

 UIManager.instance().register(UIComponent.RightPanelTabItem, {
      name: 'Name',
      value: 'value',
      render: this.createRootRenderer(ReactComponentView),
    })

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added this to the v0.5.8 milestone Oct 28, 2024
@urmauur urmauur self-assigned this Oct 28, 2024
Copy link
Contributor

github-actions bot commented Oct 28, 2024

Barecheck - Code coverage report

Total: 69.32%

Your code coverage diff: -0.12% ▾

Uncovered files and lines
FileLines
core/src/browser/views/UIManager.ts32, 41-42, 45, 54, 62, 66-67, 69, 76
web/screens/Thread/ThreadRightPanel/index.tsx86, 99, 103, 106, 111-115, 119-120, 126, 130, 133, 159-160, 175-176, 179-180, 182, 186, 190, 194, 200, 204, 242, 303-304

@urmauur urmauur removed this from the v0.5.8 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planning: Jan + Cortex Extensions UI Framework
1 participant