-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #822 - Call Events Early media call status #831
base: main
Are you sure you want to change the base?
Conversation
generally we want all PRs to reference an issue. In this case we have not created an issue yet, but please create an issue describing the problem |
While this looks like a useful event to be sending its not really solving the issue I raised as the event I'm interested in is where the caller hangs up the call during early media |
Hi @sammachin while testing this issue, we found that if the call is hangup by caller, jambonz will sent event NoAnswer, sip reason is Request Terminated. This is correct behavior, please let us know if you was not received this event. If no, please attach a log here. |
this._notifyCallStatusChange({ | ||
callStatus: CallStatus.NoAnswer, | ||
sipStatus: 487, | ||
sipReason: 'Request Terminated' | ||
}); | ||
if (wasEarlyMedia) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this event. Please consider to remove it.
NoAnswer is already good enoug as it's final status as same as Completed
Thats what I would have expected but not the behcaviour I saw, have a look at #822 for details of a call on jambonz.cloud with the issue. |
@sammachin Could you kindly supply us with another example, or reproduce the same example and provide us with the callsid where you are experiencing the problem? |
Sure, call sid 7b2165d5-2f56-4553-8472-620adea9980f at 08:08:49 UTC on 2nd August |
Fix for #822 :
You should now be able to see a call status event to indicate early media playing
Sample from my test call while recreating this issue