! fix: catch errors during initialization of the SIP client #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xquanluu
reviewed
Nov 18, 2024
| sipUA.current = sipClient; | ||
| } catch (error) { | ||
| console.error(error); | ||
| toast({ |
There was a problem hiding this comment.
what was the original issue that you faced with, how can I reproduce this issue?
There was a problem hiding this comment.
if you enter invalid content in any of the settings that causes the sipUA to error:
Two things I know will reproduce
- invalid sip endpoint (try entering nonsense, like
def) - invalid username (try including an @ in the username)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a try catch and report the error to the user about which configuration is invalid. Log additional details to the console.
Fixes: #38