Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve *.js.map files as assets #196

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Meekohi
Copy link

@Meekohi Meekohi commented May 30, 2016

Enables SourceMaps to work correctly (for example in Chrome developer tools).

Meekohi added 2 commits May 30, 2016 12:12
Enables SourceMaps to work correctly.
@StrikeForceZero
Copy link
Contributor

The source maps are essentially inlined (using comments to give path hints I believe). Unless you've modified your gulp tasks the js.map files arent written to separate files. So fetching main.js.map actually results in a 404. At least in my test case.

In this screenshot you can see chrome automatically detecting the source maps:

image

@Meekohi
Copy link
Author

Meekohi commented May 31, 2016

Hrm that is not the behavior I'm seeing -- mine generates a separate main.js.map (but then can't serve it correctly without this fix). I'll test again on a fresh install.

@jakemmarsh
Copy link
Owner

Any update on this @Meekohi?

@Meekohi
Copy link
Author

Meekohi commented Jun 6, 2016

Sorry been swamped -- still on my radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants