TypeScript: special case for auto-incrementing primary keys, v2 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jakearchibald, any updates on this getting merged or resolving #150? Thanks |
dumbmatter
force-pushed
the
autoIncrementKeyPath2
branch
from
77a082d to
ed18a1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improved version of #151, aimed at solving #150.
The general idea is that you specify the auto-incrementing key's name in
DBSchemaValue["autoIncrementKeyPath"], and then internally it labels that property as optional when accepting new records inaddandput. It even works with nested keys like"my.nested.id".As a bonus, when
autoIncrementKeyPathis set,createObjectStorenow knows what to expect in its 2nd parameter - that it must have an auto incrementing key of the same name. This will help catch some typos.The only caveat is I'm not sure how to make the 2nd parameter of
createObjectStoreoptional if and only ifautoIncrementKeyPathis undefined. See the comment I left in there.