Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to stage the core profile 11.0.0 release #782

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

starksm64
Copy link
Contributor

@starksm64 starksm64 commented Oct 16, 2024

Specification PR template

When creating a specification project release review, create PRs with the content defined as follows.

Include the following in the PR:

Note: If any item does not apply, check it and mark N/A below it.

Below are for Jakarta EE Specification Committee

Mentor Spec Review Checklist

  1. Spec PR
  1. _index.md
  1. javadocs
  • Footer contains Eclipse copyright and link to license
  • ESFL license is included, usually as doc-files/speclicense.html
  • no META-INF directory in PR
  • javadocs-jar artifact matches apidocs (optional for this release)
  1. Spec PDF
  • Correct spec title
  • Version number of the form x.y, not x.y.z
  • Correct Eclipse copyright line
  • Use version 1.1 of the EFSL
  • No DRAFT or SNAPSHOT
  • Correct Logo
  1. Spec HTML
  • Same as PDF
  1. TCK zip file
  • README file (optional for this release)
  • EFTL license file, preferably named LICENSE.md
  • User's Guide (or equivalent documentation)
  • How to test the Compatible Implementation(s) listed in _index.md above with the TCK (may be in UG)
  1. TCK User's Guide (or equivalent documentation)
  • Software requirements listed
  • Installation and configuration described
  • How to run tests
  • Where to file challenges
  1. Compatibility certification request
  • Request follows template
  • SHA-256 fingerprint matches staged TCK zip file
  • Request issue has certification label.
  1. TCK results summary
  • Page is hosted by Compatible Implementation project
  • Includes all information from certification request
  • Summary includes number of tests passed, failed, errors
  • SHA-256 fingerprint matches staged TCK zip file on cert request
  1. If a Release Review is required, the specification project team contacts the EMO to initiate the review by sending an email to [email protected].
    (A Release Review is not required if the current release is a Service Release based on a previously successful Major or Minor
    release as indicated by a release record on the project's Releases page, e.g., the Jakarta Servlet releases page.)

  2. Update Jakarta EE API jar

  • N/A Update the Jakarta EE API jar by submitting a PR to the jakartaee-api project that updates the version number of your API jar file.

Mentor Final Tasks after a Successful Release Review

  • adds this final checklist to the main PR.
  • adds the approved label to the PRs, and sends out the Ballot Summary per this template to the public Jakarta EE Specification Committee email list
  • calculates the staged EFTL TCK signature and promotes it to the committee download area
    using the https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/ job. Manually editing the jenkins Build Information will help identify the build (ie. Mail 2.0 or CDI 3.0).
  • merges the specification (and apidocs) PRs, ensuring the "date:" field in the _index.md file has an appropriate value to allow publishing.
  • updates the specification page with the ballot results. This is normally done via a separate PR that should be reviewed, approved, and merged.
  • notifies the EMO of the ballot results by email to [email protected]. Just forward the ballot summary note sent earlier to the public Spec Committee email list.
  • creates an issue in the specification project that includes the following checklist for the specification project team:
    (an example can be found here.)
- [ ] promote api staging release promotes the specification api jars to maven central. An example release job script can be found here https://wiki.eclipse.org/MavenReleaseScript
- [ ] go through the merged jakarta.ee specification website page to verify all the links are valid
- [ ] if XML Schemas are published on https://jakarta.ee/schemas, send a PR to update the status from `Draft` to `Final`
- [ ] approve the compatibility request
- [ ] merge any final release branch as appropriate for the branch management for the project

@starksm64 starksm64 marked this pull request as draft October 16, 2024 22:00
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for jakartaee-specifications ready!

Name Link
🔨 Latest commit 127f9e1
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee-specifications/deploys/673621f18864a600088c38f9
😎 Deploy Preview https://deploy-preview-782--jakartaee-specifications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@starksm64
Copy link
Contributor Author

The 11.0.0 core proflie tck has been respun and this is the updated bundle info for the staged eftl binary:

***********************************************************************************
***                        TCK bundle information                               ***
*** Name:       jakarta-core-profile-tck-11.0.0.zip                                     ***
*** Bundle Copied to URL:    http://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl//jakarta-core-profile-tck-11.0.0.zip ***
*** Date and size: date: 2024-10-31 00:21:40.078183463 +0000, size(b): 170551        ***
*** SHA256SUM: 5722bac4f1af78e93ede95feaa448aa0bc19934d0871415c25dd45ffa8c5d1a5 ***
***                                                                             ***
***********************************************************************************

The maven artifacts are also staged with repository ID jakartatck-1111.
https://jakarta.oss.sonatype.org/content/groups/staging/jakarta/tck/coreprofile/core-profile-tck-dist/11.0.0/

Name Last Modified Size Description
Parent Directory
core-profile-tck-dist-11.0.0-cyclonedx.json Thu Oct 31 00:22:55 UTC 2024 339093  
core-profile-tck-dist-11.0.0-cyclonedx.json.asc Thu Oct 31 00:23:07 UTC 2024 833  
core-profile-tck-dist-11.0.0-cyclonedx.json.md5 Thu Oct 31 00:22:55 UTC 2024 32  
core-profile-tck-dist-11.0.0-cyclonedx.json.sha1 Thu Oct 31 00:22:55 UTC 2024 40  
core-profile-tck-dist-11.0.0-cyclonedx.xml Thu Oct 31 00:22:54 UTC 2024 293535  
core-profile-tck-dist-11.0.0-cyclonedx.xml.asc Thu Oct 31 00:23:01 UTC 2024 833  
core-profile-tck-dist-11.0.0-cyclonedx.xml.md5 Thu Oct 31 00:22:54 UTC 2024 32  
core-profile-tck-dist-11.0.0-cyclonedx.xml.sha1 Thu Oct 31 00:22:54 UTC 2024 40  
core-profile-tck-dist-11.0.0.pom Thu Oct 31 00:22:52 UTC 2024 7247  
core-profile-tck-dist-11.0.0.pom.asc Thu Oct 31 00:22:55 UTC 2024 833  
core-profile-tck-dist-11.0.0.pom.md5 Thu Oct 31 00:22:53 UTC 2024 32  
core-profile-tck-dist-11.0.0.pom.sha1 Thu Oct 31 00:22:53 UTC 2024 40  
core-profile-tck-dist-11.0.0.zip Thu Oct 31 00:23:08 UTC 2024 170551  
core-profile-tck-dist-11.0.0.zip.asc Thu Oct 31 00:23:08 UTC 2024 833  
core-profile-tck-dist-11.0.0.zip.md5 Thu Oct 31 00:23:09 UTC 2024 32  
core-profile-tck-dist-11.0.0.zip.sha1 Thu Oct 31 00:23:08 UTC 2024 40  

@ivargrimstad
Copy link
Member

Hi @starksm64,

Here are the core profile specification documents (PDF and HTML) for you to add to the PR.
jakarta-coreprofile-spec-11.0.zip

@starksm64 starksm64 marked this pull request as ready for review November 7, 2024 15:33
@starksm64
Copy link
Contributor Author

@ivargrimstad those have been added. It looks like the final apidocs are still needed.

@ivargrimstad
Copy link
Member

The API docs are in a separate PR.

@starksm64
Copy link
Contributor Author

Ok, then should be good to go.

@Emily-Jiang
Copy link
Contributor

Emily-Jiang commented Nov 7, 2024

@starksm64 the TCK is missing from the deployed view. Please see the Jakarta Core Profile 10.0 TCK (sig, sha, pub))

coreprofile/11/_index.md Outdated Show resolved Hide resolved
@Emily-Jiang
Copy link
Contributor

The software requirement was wrong:

  • A Java SE 11+ runtime
  • Maven 3.6.x +

@Emily-Jiang
Copy link
Contributor

The examples folder wf-core-tck-runner in the tck jar is empty.

@tjwatson
Copy link
Member

tjwatson commented Nov 7, 2024

The TCK license is:

Eclipse Foundation Technology Compatibility Kit License - v 1.0

Just double checking that we do not require v 1.1 to be used at https://www.eclipse.org/legal/tck/.

@tjwatson
Copy link
Member

tjwatson commented Nov 7, 2024

TCK reference guide section 3.2 has the wrong EE version

3.2. Jakarta EE 10 Runtime
Executing the TCK requires a Jakarta EE 10 ...

@Emily-Jiang
Copy link
Contributor

@starksm64 please address all of the above comments from me and @tjwatson

@starksm64
Copy link
Contributor Author

The remaining changes are going to require another respin of the coreprofile tck.

@TanjaObradovic
Copy link

Thanks @starksm64

@ivargrimstad
Copy link
Member

Thanks @starksm64! Can you also list the two compatible implementations used for ratification (as is done for Core Profile 10)?

  • Compatible Implementations used for ratification.
  • WildFly
  • Open Liberty

@starksm64
Copy link
Contributor Author

Thanks @starksm64! Can you also list the two compatible implementations used for ratification (as is done for Core Profile 10)?

  • Compatible Implementations used for ratification.
  • WildFly
  • Open Liberty

I added the names, if we want the links to the downloads that will need to be added.

@Emily-Jiang
Copy link
Contributor

By the way, after the core profile respin, the existing CCR from Open Liberty and Wildfly need to be redone.

@ivargrimstad
Copy link
Member

By the way, after the core profile respin, the existing CCR from Open Liberty and Wildfly need to be redone.

Has the TCK been updated again? They both have been respun once.

@ivargrimstad
Copy link
Member

By the way, after the core profile respin, the existing CCR from Open Liberty and Wildfly need to be redone.

Has the TCK been updated again? They both have been respun once.

Ah, I see it now. The updates to the user guide etc... I'll back the approved label from the CCRs so it Is reflected there

@starksm64
Copy link
Contributor Author

The 11.0.0 core profile has been respun again and has been staged and uploaded to the project download area. The new info is:

***********************************************************************************
***                        TCK bundle information                               ***
*** Name:       jakarta-core-profile-tck-11.0.0.zip                                     ***
*** Bundle Copied to URL:    http://download.eclipse.org/ee4j/jakartaee-tck/jakartaee11/staged/eftl//jakarta-core-profile-tck-11.0.0.zip ***
*** Date and size: date: 2024-11-14 18:20:10.444442915 +0000, size(b): 224670        ***
*** SHA256SUM: 0357bfab7025972edb2bf50277b6b4206b499a2961bc94e783f34782cc4a9bda ***
***                                                                             ***
***********************************************************************************

The maven artifacts are also staged with repository ID jakartatck-1112.
https://jakarta.oss.sonatype.org/content/groups/staging/jakarta/tck/coreprofile/core-profile-tck-dist/11.0.0/

Name Last Modified Size Description
Parent Directory
core-profile-tck-dist-11.0.0-cyclonedx.json Thu Nov 14 18:22:03 UTC 2024 339093  
core-profile-tck-dist-11.0.0-cyclonedx.json.asc Thu Nov 14 18:22:22 UTC 2024 833  
core-profile-tck-dist-11.0.0-cyclonedx.json.md5 Thu Nov 14 18:22:04 UTC 2024 32  
core-profile-tck-dist-11.0.0-cyclonedx.json.sha1 Thu Nov 14 18:22:03 UTC 2024 40  
core-profile-tck-dist-11.0.0-cyclonedx.xml Thu Nov 14 18:22:02 UTC 2024 293535  
core-profile-tck-dist-11.0.0-cyclonedx.xml.asc Thu Nov 14 18:22:13 UTC 2024 833  
core-profile-tck-dist-11.0.0-cyclonedx.xml.md5 Thu Nov 14 18:22:02 UTC 2024 32  
core-profile-tck-dist-11.0.0-cyclonedx.xml.sha1 Thu Nov 14 18:22:02 UTC 2024 40  
core-profile-tck-dist-11.0.0.pom Thu Nov 14 18:21:59 UTC 2024 7349  
core-profile-tck-dist-11.0.0.pom.asc Thu Nov 14 18:22:04 UTC 2024 833  
core-profile-tck-dist-11.0.0.pom.md5 Thu Nov 14 18:21:59 UTC 2024 32  
core-profile-tck-dist-11.0.0.pom.sha1 Thu Nov 14 18:21:59 UTC 2024 40  
core-profile-tck-dist-11.0.0.zip Thu Nov 14 18:22:24 UTC 2024 169940  
core-profile-tck-dist-11.0.0.zip.asc Thu Nov 14 18:22:23 UTC 2024 833  
core-profile-tck-dist-11.0.0.zip.md5 Thu Nov 14 18:22:24 UTC 2024 32  
core-profile-tck-dist-11.0.0.zip.sha1 Thu Nov 14 18:22:24 UTC 2024 40

@starksm64
Copy link
Contributor Author

The TCK license is:

Eclipse Foundation Technology Compatibility Kit License - v 1.0

Just double checking that we do not require v 1.1 to be used at https://www.eclipse.org/legal/tck/.

This was updated to 1.1 since I had to update the TCK anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants