Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation changes to README #274

Open
wants to merge 1 commit into
base: v4
Choose a base branch
from
Open

Conversation

JasonHo420
Copy link

Added an Introduction and a Background that describes what basketball reference is.

Copy link
Owner

@jaebradley jaebradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JasonHo420 apologies for the delayed review!

Thanks for opening this PR to add more information to the README file.

My preference is to move as much information as possible to the documentation site (https://jaebradley.github.io/basketball_reference_web_scraper/).

You can see the content for the documentation site in the docs folder (like https://github.com/jaebradley/basketball_reference_web_scraper/blob/v4/docs/index.md).

I think we can condense the information here into additional content contained within docs/index.md - does that seem reasonable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants