Allow multiple routing key bindings #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedMMahfouz
force-pushed
the
allow-multiple-routing-keys-binding
branch
4 times, most recently
from
33e64b0 to
d5eae8b
Compare
MohamedMMahfouz
force-pushed
the
allow-multiple-routing-keys-binding
branch
from
d5eae8b to
fb285e0
Compare
MohamedMMahfouz
requested review from
johannesluedke and
brerx
as code owners
|
@mblumtritt I'd like to have your opinion on the interface change. Can we do it in a less breaking way? |
mblumtritt
reviewed
Nov 8, 2023
mblumtritt
reviewed
Nov 8, 2023
| def self.configure(opts = {}) | ||
| self.queue = opts.fetch(:queue) | ||
| self.exchange = opts.fetch(:exchange) | ||
| self.routing_key = opts.fetch(:routing_key) | ||
| self.routing_keys = opts.fetch(:routing_keys) |
There was a problem hiding this comment.
You can keep backward compatibility:
routing_keys = opts[:routing_keys] || []
routing_keys << opts[:routing_key] if opts.key?(:routing_key)
self.routing_keys = routing_keysBut since the attribute also changed I would go with the :routing_keys.
Co-authored-by: Mike Blumtritt <[email protected]>
brerx
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.