Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: flatten pageType registration configuration structure #27

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

schloram
Copy link
Member

With this change we are getting rid of the configure config sub-level. I didn't really understand why we separated the config like this in the first place.

old:

dokType: 87
configuration:
  label: 'My Custom pageType'
  iconSet:
    defaultIcon:
      source: 'EXT:your_ext/Resources/Public/Icons/apps-pagetree-mycustompagetype.svg'
    hideInMenuIcon:
      identifier: 'apps-pagetree-page-frontend-user-hideinmenu'
    rootPageIcon:
      source: 'EXT:your_ext/Resources/Public/Icons/apps-pagetree-mycustompagetype-root.svg'
  isDraggableInNewPageDragArea: true

new:

dokType: 87
label: 'My Custom pageType'
iconSet:
  defaultIcon:
    source: 'EXT:your_ext/Resources/Public/Icons/apps-pagetree-mycustompagetype.svg'
  hideInMenuIcon:
    identifier: 'apps-pagetree-page-frontend-user-hideinmenu'
  rootPageIcon:
    source: 'EXT:your_ext/Resources/Public/Icons/apps-pagetree-mycustompagetype-root.svg'
isDraggableInNewPageDragArea: true

In perspective of making the default icon optional (#26) the minimal pageType setup would be as simple as:

dokType: 87
label: 'My Custom pageType'

instead of:

dokType: 87
configuration:
  label: 'My Custom pageType'

@schloram schloram marked this pull request as ready for review October 17, 2023 07:51
@schloram schloram requested a review from vacijj October 17, 2023 07:51
@vacijj vacijj merged commit dfd4628 into main Oct 17, 2023
@vacijj vacijj deleted the flatten-structure-of-config branch October 17, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants