Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit when backupsink stopped also fix NPE when negative offset #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

discanto
Copy link

No point in keeping the process going when the BackupSinkTask is killed.
Exiting will allow monitoring/daemon systems to restart or otherwise take action on all the RuntimeExceptions thrown.

@discanto discanto changed the title Exit when backupsink stopped Exit when backupsink stopped also fix NPE when negative offset Aug 10, 2020
@discanto
Copy link
Author

The NPE can happen when there is a consumer-group without a topic, even adminclient < 2.4.1 fails to describe such a group, see the fix for it here https://issues.apache.org/jira/browse/KAFKA-9507. Only deleting such consumer-groups can allow kafka-backup to proceed.

Copy link
Owner

@itadventurer itadventurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think we should split it in two PRs and I do not fully understand whether it is ok to simply continue when we encounter the linked issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants