[17.0] [MIG] tg_sale_commission #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwhatk0k3
force-pushed
the
17.0-mig-tg_sale_commission
branch
from
5e5e12b to
fceabeb
Compare
em230418
requested changes
Oct 17, 2024
Comment on lines
11
to
15
| <xpath expr="//page[@name='agent_information']/group" position="before"> | ||
| <group> | ||
| <field name="agent" /> | ||
| </group> | ||
| </xpath> |
There was a problem hiding this comment.
Раз уже есть поле "Agent" под "Tax ID", предлагаю убрать это-же поле во вкладке agent information
tg_sale_commission/__manifest__.py
Outdated
| "views/res_partner_views.xml", | ||
| "views/sale_affiliate_views.xml", | ||
| ], | ||
| "test_tags": "-sale_commission", |
There was a problem hiding this comment.
Для чего ввели этот test_tags? Вроде как тут нету тестов, которые тегируются как sale_commission.
kwhatk0k3
force-pushed
the
17.0-mig-tg_sale_commission
branch
3 times, most recently
from
f003f68 to
496f79e
Compare
kwhatk0k3
force-pushed
the
17.0-mig-tg_sale_commission
branch
from
496f79e to
77299b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[17.0] [MIG] tg_sale_commission