Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated spawn-wrap to v1.3.5. Fixes #577. #578

Closed
wants to merge 1 commit into from
Closed

Updated spawn-wrap to v1.3.5. Fixes #577. #578

wants to merge 1 commit into from

Conversation

cb1kenobi
Copy link

No description provided.

@coveralls
Copy link

coveralls commented May 24, 2017

Coverage Status

Changes Unknown when pulling 8d88dc8 on cb1kenobi:update-spawn-wrap into ** on istanbuljs:master**.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8d88dc8 on cb1kenobi:update-spawn-wrap into ** on istanbuljs:master**.

@bcoe
Copy link
Member

bcoe commented May 24, 2017

@cb1kenobi this can't be landed currently, due to:

istanbuljs/spawn-wrap#44

@cb1kenobi
Copy link
Author

@bcoe Well that's a bummer. I filed istanbuljs/spawn-wrap#54, so I suppose I could take a crack at fixing istanbuljs/spawn-wrap#44 too. Stay tuned.

Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to prod @isaacs and see if we can't figure out the infinite loop issue with spawn-wrap; I have an open issue on spawn-wrap that at least isolates the line of code causing the issue.

@cb1kenobi
Copy link
Author

Now that [email protected] was just published and it fixes istanbuljs/spawn-wrap#44, we should close this PR and whichever commit updates the spawn-wrap version in the package.json can mark #577 as fixed.

@cb1kenobi cb1kenobi closed this Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants