test: remove dependency on "true" which is not on all windows sytems

test: add --fix command for easier local development build: turn off npm updates which were causing issues with snapshots Co-authored-by: Austin Akers <[email protected]> Co-authored-by: Austin Akers <[email protected]>
istanbuljs · Apr 19, 2024 · 8120112 · 8120112
1 parent f6e5aba
commit 8120112
Show file tree

Hide file tree

Showing 8 changed files with 49 additions and 17 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -19,7 +19,7 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
           cache: npm
-      - run: npm i npm@latest -g
+      - run: npm config set update-notifier false
       - run: npm ci --engine-strict
       - run: npm test
   windows:
@@ -30,6 +30,6 @@ jobs:
         with:
           node-version: lts/*
           cache: npm
-      - run: npm i npm@latest -g
+      - run: npm config set update-notifier false
       - run: npm ci
       - run: npm test
diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml
@@ -21,7 +21,6 @@ jobs:
       - uses: actions/setup-node@v3
         with:
           node-version: 16
-          registry-url: 'https://external-dot-oss-automation.appspot.com'
           cache: npm
         if: ${{ steps.release.outputs.release_created }}
       - run: npm publish

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -8,6 +8,7 @@
     "pretest": "npm run lint && npm run clean && npm run instrument",
     "test": "tap",
     "snap": "npm test -- --snapshot",
+    "fix": "standard --fix",
     "posttest": "npm run report",
     "clean": "node ./npm-run-clean.js",
     "instrument": "node ./build-self-coverage.js",
@@ -68,7 +69,7 @@
     "glob": "^7.1.6",
     "istanbul-lib-coverage": "^3.0.0",
     "istanbul-lib-hook": "^3.0.0",
-    "istanbul-lib-instrument": "^4.0.0",
+    "istanbul-lib-instrument": "^6.0.2",
     "istanbul-lib-processinfo": "^2.0.2",
     "istanbul-lib-report": "^3.0.0",
     "istanbul-lib-source-maps": "^4.0.0",

diff --git a/tap-snapshots/test/nyc-integration.js.test.cjs b/tap-snapshots/test/nyc-integration.js.test.cjs
@@ -888,6 +888,7 @@ exports[`test/nyc-integration.js > TAP > passes configuration via environment va
 `
 
 exports[`test/nyc-integration.js > TAP > recursive run does not throw > stdout 1`] = `
+hello
 
 `
 

diff --git a/test/helpers/run-nyc.js b/test/helpers/run-nyc.js
@@ -47,8 +47,8 @@ async function runNYC ({ args, tempDir, leavePathSep, cwd = fixturesCLI, env = {
       stderr,
       stdout
     },
-    stderr: sanitizeString(stderr, cwd, leavePathSep),
-    stdout: sanitizeString(stdout, cwd, leavePathSep)
+    stderr: sanitizeString(stderr.toString('utf8'), cwd, leavePathSep),
+    stdout: sanitizeString(stdout.toString('utf8'), cwd, leavePathSep)
   }
 }
 

diff --git a/test/helpers/test-success.js b/test/helpers/test-success.js
@@ -10,7 +10,6 @@ async function testSuccess (t, opts) {
 
   t.equal(status, 0)
   t.equal(stderr, '')
-  console.info(stdout)
   t.matchSnapshot(stdout, 'stdout')
 }
 

diff --git a/test/nyc-integration.js b/test/nyc-integration.js
@@ -591,7 +591,8 @@ t.test('recursive run does not throw', t => testSuccess(t, {
     nycBin,
     process.execPath,
     nycBin,
-    'true'
+    'echo',
+    'hello'
   ],
   cwd: path.resolve(__dirname, 'fixtures/recursive-run')
 }))