Nixify / Allow the use of a global binary #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch global setting add everything to packages
working more on vim plugin working more on vim plugin working more on vim plugin add echo statement enable rpc add more logging give it the cwd? test listen address listen address was wrong try require try rpcstart cleanup
JonathanLorimer
commented
Feb 7, 2022
Comment on lines
+1
to
+3
| if exists("g:cornelis_use_global_binary") | ||
| call remote#host#Register('cornelis', '*', rpcstart('cornelis', [])) | ||
| else |
There was a problem hiding this comment.
In the future we could allow people to provide the global binary path as a string, but for now this works for me!
There was a problem hiding this comment.
Might be a good thing to tackle at the same time as #12
|
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29