AWS EKS cleanup fix. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the quick fix for the AWS cleaner to remove EKS depended resources. The SDK ELB package works only with `classic` load balancers. To list and remove `network` or `application` ELBs we need to use SDK ELB V2 package: `github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2`.
Initial implementation assumption was that cluster should be removed at the end of the cleanup proccess. This allows to restart cleanup proccess from scratch in case of dependency cleanup issues. But for some EKS setups we might have ENIs attached directly to a cluster. That blocks VPC deletion while ENIs exist. The ENIs are deleted automatically after cluster deletion. So, I moved cluster drop to the beginning of the proccess.
auriaave
previously approved these changes
Nov 7, 2024
The function `deleteVpcAndEks` refactored to avoid errors lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(please see the commit messages)