Accept waitForNavigation options

isleofcode · Aug 1, 2019 · e4e049d · e4e049d
1 parent 863f2e0
commit e4e049d
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/src/renderers/chrome/index.js b/src/renderers/chrome/index.js
@@ -114,14 +114,27 @@ export class ChromeRenderer extends Renderer {
   }
 
   async renderPage(page, options = {}) {
-    let { path: filepath, type } = options;
+    let { path: filepath, type, waitForNavigation } = options;
     let buffer;
 
     if (!isString(type)) {
       type = isString(filepath) ? path.extname(filepath).slice(1) : 'html';
       type = type.length > 0 ? type : 'html';
     }
 
+    if (waitForNavigation !== false) {
+      if (waitForNavigation === Object(waitForNavigation)) {
+        await page._chromePage.waitForNavigation(waitForNavigation);
+      } else {
+        await page._chromePage.waitForNavigation({
+          waitUntil: 'networkidle',
+          networkIdleInflight: 0,
+          timeout: 0
+        });
+      }
+      delete options.waitForNavigation;
+    }
+
     switch (type) {
       case 'html':
         buffer = await page._chromePage.content();
@@ -134,12 +147,6 @@ export class ChromeRenderer extends Renderer {
           delete options.emulateMedia;
         }
 
-        await page._chromePage.waitForNavigation({
-          waitUntil: 'networkidle',
-          networkIdleInflight: 0,
-          timeout: 0
-        });
-
         buffer = await page._chromePage.pdf(options);
         break;
       default: